Skip to content

Fixed broken person_detection example (TFMIC-50) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed broken person_detection example (TFMIC-50) #107

wants to merge 1 commit into from

Conversation

@ShardulNalegave
Copy link
Contributor

@ShardulNalegave ShardulNalegave commented Jan 28, 2025

  • Bumped esp32_s3_eye dependency version number
  • Made changes to CMakeLists.txt to fix BSP packages not getting installed
  • Fixed issues with LVGL which caused the display to fail

Description

The person_detection example is broken due to a few issues.

  1. Currently, the correct BSP packages don't get installed even after selecting the right option in menuconfig
  2. The esp32_s3_eye dependency is set to a older version (3.x) which causes errors with i2c
  3. Display doesn't work because of issues with LVGL initialisation

This PR addresses these issues.

Testing

Dependency installation related issues were testing by setting options from menuconfig and checking stdout during idf.py build

The complete example was tested on a ESP32 S3 Eye

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions github-actions bot changed the title Fixed broken person_detection example Fixed broken person_detection example (TFMIC-50) Jan 28, 2025
@ShardulNalegave ShardulNalegave force-pushed the person_detection_fix branch 2 times, most recently from ca1a722 to 1edd78e Compare January 29, 2025 12:41
vikramdattu
vikramdattu reviewed Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@vikramdattu vikramdattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, also please squash the commits into one.

@ShardulNalegave
Copy link
Contributor Author

ShardulNalegave commented Jan 30, 2025

Added some comments, also please squash the commits into one.

Yes sir, will do that once all issues/corrections are resolved.

@vikramdattu
Copy link
Collaborator

vikramdattu commented Feb 17, 2025

Build fails on ESP32:

pp_camera_esp.c
In file included from /builds/app-frameworks/esp-tflite-micro/examples/person_detection/main/app_camera_esp.c:16:
/builds/app-frameworks/esp-tflite-micro/examples/person_detection/main/app_camera_esp.h:19:10: fatal error: sensor.h: No such file or directory
   19 | #include "sensor.h"
      |          ^~~~~~~~~~
compilation terminated.

@ShardulNalegave
Copy link
Contributor Author

ShardulNalegave commented Feb 17, 2025

I've made the required fixes, the example should build successfully now

@vikramdattu
Copy link
Collaborator

vikramdattu commented Feb 17, 2025

I've made the required fixes, the example should build successfully now

@ShardulNalegave the build issue was introduced in the previous commit. So, instead of adding new bugfix commit, please amend this to your original commit.

@ShardulNalegave
Copy link
Contributor Author

ShardulNalegave commented Feb 17, 2025

okay sir, I've made the changes. The previous commit has now been amended instead of pushing a new bugfix commit

@vikramdattu
Copy link
Collaborator

vikramdattu commented Mar 24, 2025

Hi @ShardulNalegave please rebase it on latest master. This run CI for any build issues.

@ShardulNalegave
Fixed broken person_detection example
782b3f4 
- Bumped esp32_s3_eye dependency version number
- Made changes to CMakeLists.txt to fix BSP packages not getting installed
- Fixed issues with LVGL which caused the display to fail
@ShardulNalegave
Copy link
Contributor Author

ShardulNalegave commented Mar 24, 2025

Sure sir, done as requested.

@vikramdattu
Copy link
Collaborator

vikramdattu commented Mar 26, 2025

Please fix the build for release/v4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramdattu vikramdattu vikramdattu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShardulNalegave @vikramdattu